Fix "Unknown downloader type: npm-signature" exception

fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer

MIT License

893 stars 156 forks source link

Fix "Unknown downloader type: npm-signature" exception #324

Closed hypeJunction closed 6 years ago

hypeJunction commented 6 years ago

Dist entry resolution is now restricted to downloader types known by composer. Effectively this means that composer-asset-plugin will skip all dist entries that link to custom vendor protocol implementations, e.g. npm-signature.

Fixes #321

Replaces #323

francoispluchino commented 6 years ago

Thank you for your PR, but can you use the tool php-cs-fixer to respect the code style? I still have to add the doc for contributions.

Download/Install the tool
Run the command: $ php php-cs-fixer.phar fix

hypeJunction commented 6 years ago

Well, cs-fixer fixed unrelated cs violations...

francoispluchino commented 6 years ago

Ok, new rules have been introduced since the last commit. Can you keep only the code fixing the bug for this PR, and if you wish, propose another PR for the CS? Otherwise I will do this last....

I could quickly merge your PRs. Thank you.

francoispluchino commented 6 years ago

@hypeJunction Thank you!