fxpio / composer-asset-plugin

NPM/Bower Dependency Manager for Composer
MIT License
893 stars 156 forks source link

Added `url` repository type support #331

Closed SilverFire closed 4 years ago

SilverFire commented 4 years ago

Hi, François!

We've got an issue that npm/ascli package does not get fetched.

The reason is that they set repository.type = url that is not supported. I haven't found any specification on allowed repository type values, but if you think this change is acceptable – please, merge it.

francoispluchino commented 4 years ago

Fix the tests please :-)

francoispluchino commented 4 years ago

Can you revert your last commit because finally added by 1aa6503e8c544c3d8d89cfc86654fefd9a646e08, and squash your PR ? I will merge your PR just after. Thank you :-)

SilverFire commented 4 years ago

Rebased

francoispluchino commented 4 years ago

@SilverFire Thank you!

SilverFire commented 4 years ago

Thank you too, @francoispluchino