Teached Foxy the difference between development-dependencies and production-dependencies

fxpio / foxy

A fast, reliable, and secure NPM/Yarn/pnpm bridge for Composer

https://foxypkg.com

MIT License

173 stars 21 forks source link

Teached Foxy the difference between development-dependencies and production-dependencies #32

Closed rdss-hmorsi closed 3 years ago

rdss-hmorsi commented 4 years ago

Foxy now distinguishes between development-dependencies and production-dependencies. So a "composer install --no-dev" will not result in a different package-lock.json when composer packages have npm-dependencies. Solving this issue: https://github.com/fxpio/foxy/issues/31

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 54e278f7c14d25d8c4016e1c33626bef4f19dbc4 on ZooRoyal:master into 30e9952806b3678a8b16eff2db3fb932e08463ed on fxpio:master.

rdss-sknott commented 4 years ago

hey @francoispluchino did you had a chance to look at our PR? Is there something we can do to help or adapt?

francoispluchino commented 3 years ago

@rdss-hmorsi Sorry for the very long wait ...

There have been some changes in the meantime, so is it possible, can you please, to rebase your PR with the 1.2 main branch and also, do only one commit?

rdss-hmorsi commented 3 years ago

HI, we switched to a different solution and are no longer requiring your package as a dependency in our project.