fxpio / foxy

A fast, reliable, and secure NPM/Yarn/pnpm bridge for Composer
https://foxypkg.com
MIT License
173 stars 21 forks source link

v1.2.0 no more works with PHP less than 7.1 #43

Closed gajdusek closed 2 years ago

gajdusek commented 2 years ago

Thank you for creating this excellent composer plugin!

Commit 7d3d8242b47ab introduced at least one PHP 7.1+ feature, a nullable type, in

public function __construct(
        IOInterface $io,
        Config $config,
        ProcessExecutor $executor,
        Filesystem $fs,
        FallbackInterface $fallback = null,
        ?VersionConverterInterface $versionConverter = null
    ) {
        $this->io = $io;
        ...
   }

Despite this breaking change the foxy version number did not bump to 2.0.0 and composer.json still requires only php >= 5.3.3:

{
    ...
    "require": {
        "php": ">=5.3.3",
        ...
    },
    ...

This is the first error encountered when running composer with PHP < 7.1. Maybe there are more.

Petr

francoispluchino commented 2 years ago

I thank you for your feedback. This needs to be fixed.

francoispluchino commented 2 years ago

Fixed by c4154031e18ff404f07608c6778c30bd9afe9966.