DRAFT: Making it compatible with composer ^2.5 as php is throwing an error.

fxpio / foxy

A fast, reliable, and secure NPM/Yarn/pnpm bridge for Composer

https://foxypkg.com

MIT License

173 stars 21 forks source link

DRAFT: Making it compatible with composer ^2.5 as php is throwing an error. #48

Open fr3nch13 opened 11 months ago

fr3nch13 commented 11 months ago

The error:

PHP Fatal error:  Declaration of Foxy\Json\JsonFile::encode($data, $options = 448) must be compatible with Composer\Json\JsonFile::encode($data, int $options = 448, string $indent = self::INDENT_DEFAULT): string in vendor/foxy/foxy/Json/JsonFile.php on line 98

This will also bump the minimum for php to ^7.3, but come on. just let php 5.x die!

Maybe this should be a PR to a new branch called 2.0 or something?

I'll be adding to this PR, so I prefixed it with DRAFT.

mambax7 commented 11 months ago

Same problem here. Thank you for the update. Hopefully, it will be accepted soon! :)

joester89 commented 8 months ago

Is there an idea when this will be merged?

francoispluchino commented 8 months ago

Thank you for your feedbacks.

Unfortunately, this Pull Request goes way too far beyond the scope of the topic, namely, making it compatible with Composer 2.5 and above. I'm not going to go into details, but as it stands, all of the proposed changes mainly concern the style of code and CI using Github Actions whereas the project is tested with Travis CI. In addition, this PR does not respect the project's PHP CS Fixer configurations.

In the event that this PR is simplified to what it describes or another PR does this, I would voluntarily merge it.