search

fxsound2 / fxsound-app

FxSound application and DSP source code
GNU General Public License v3.0
1.06k stars 84 forks source link

Clicking the X button from the alt-tab screen quits FxSound #113

Open pie-flavor opened 2 months ago

pie-flavor commented 2 months ago

Describe the bug In the alt-tab menu, there is an X button above the window preview and it is supposed to do the same thing as clicking the X button in the application. It does not. The X button in the application minimizes it to tray and the X button in the alt-tab screen quits the application.

To Reproduce Steps to reproduce the behavior:

  1. Open FxSound from the tray menu.
  2. Hold Alt+Tab.
  3. While holding Alt+Tab, click the X button in the alt-tab preview.
  4. Observe that the application has fully quit and the audio device has been reset.

Expected behavior The application to minimize to tray, same as the X button in the application.

Screenshots image

System information

doolhoofd commented 2 months ago

Okay... I've been running Windows since childhood, and have never heard of or used this function until today. Perhaps it follows the tray icon's own logic into the Exit option?

Exit

Hi @bvijay74; Just curious what your opinion on this one would be?

bvijay74 commented 2 months ago

I compared the Alt-Tab, preview window close button press behaviour in other applications. Application that minimise to the system tray are minimising and other task bar applications which don't have a system tray icon are closing. To make FxSound behaviour similar to other system tray applications on Windows, we have to minimise it instead of quitting the application. We can look into the code changes required for this fix.