fxsound2 / fxsound-app

FxSound application and DSP source code
GNU General Public License v3.0
1.5k stars 124 forks source link

1.1.25.0 & Windows 7 #146

Open raddyst opened 2 months ago

raddyst commented 2 months ago

If fxsound have Launch on system startup option in settings (disabled by install), why are you adding shortcut to Startup folder in Start menu, that cannot be disabled or removed by fxsound?

Describe the bug CPU high Load (>25%), when i'm open settings menu.

To Reproduce Go to fxsound and open Settings menu.

Screenshots image image

System information

bvijay74 commented 2 months ago

The installer configures startup in %PROGRAMDATA%\Microsoft\Windows\Start Menu\Programs\Startup. Since application run in standard user context cannot modify the link in %PROGRAMDATA%,, for addressing the request from the community, the startup enable/disable feature is added through registry change under HKCU. And this works only on Windows 7.

raddyst commented 2 months ago

The installer configures startup in %PROGRAMDATA%\Microsoft\Windows\Start Menu\Programs\Startup. Since application run in standard user context cannot modify the link in %PROGRAMDATA%

You can use startup from user profile folder, i.e. C:\Users\<username>\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup (CSIDL_STARTUP)

bvijay74 commented 2 months ago

Startup is set by the installer and by default the installer installs in for all users. If we want to change the startup to user profile folder, we need to change the installation to per user. This may impact users who have been installing for all users.

raddyst commented 2 months ago

Startup is set by the installer and by default the installer installs in for all users. If we want to change the startup to user profile folder, we need to change the installation to per user. This may impact users who have been installing for all users.

Ok, i know about https://github.com/fxsound2/fxsound-app/issues/18#issuecomment-1980989446 - but read issue https://github.com/fxsound2/fxsound-app/issues/107

Launch from the registry is also available on Windows 10+, but it cannot be disabled using current versions of fxsound. Do you think this has no impacts on users?

fxsound is installed automatically, without any user interaction - this is the main problem ( https://github.com/fxsound2/fxsound-app/issues/105 https://github.com/fxsound2/fxsound-app/issues/63 ).