search

fy17ohhh / pe

0 stars 0 forks source link

Error adding a person with duplicate and existing attributes #3

Open fy17ohhh opened 2 months ago

fy17ohhh commented 2 months ago

When adding a person with duplicate names, but with the previous(other than the last) value existed in the system, the app will throws an error.

However, is its expected that the last attribute value is taken and a new person is successfully added.

image.png

nus-pe-bot commented 2 months ago

Team's Response

Its explicitly written that multiple same attribute names will actually be rejected and thrown the error in the UG. This is the intended outcome for our app and is not a functionality bug as it actually the correct implementation of what we intended as written explictily in the UG. Screenshot 2024-04-21 at 5.49.14 PM.png

To further illustrate that this is the intended implementation of our app, it is even given in the UG example.

Screenshot 2024-04-21 at 5.49.50 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This bug is from the add command, not the addAttribute command. According to the Developer Guide,

image.png It did not mention that duplicate attributes are checked for the add command. Also in UG there is no description about this case.

Should be a functionality bug as it is not working as expected as described in DG. May cause occasional inconvenience to some users when they expect the system to add a new person successfully, but failed to do so; and could not figure out what is the invalid part of the command.