search

fydrah / loginapp

Web application for Kubernetes CLI configuration with OIDC
Apache License 2.0
77 stars 20 forks source link

Allow empty clientSecret #56

Open dborysenko opened 2 years ago

dborysenko commented 2 years ago

Is your feature request related to a problem? Please describe. It is a valid use case where OIDC Provider does not require client secret for a client. It would make sense to allow loginapp to accept no client secret.

Describe the solution you'd like Make clientSecret field optional.

Describe alternatives you've considered

Additional context

fydrah commented 2 years ago

Hi @dborysenko !

Ok, I didn't know this was possible, by any chance do you have an example or a documentation I could refer to for testing purpose?

dborysenko commented 2 years ago

Hey @fydrah, Thanks for quick response. My use case is AWS EKS clusters using OIDC provider for authentication/authorization. EKS do not require clientSecret, moreover it does not even support clientSecret. Please refer to AWS doc: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-identityproviderconfig-oidcidentityproviderconfig.html

adrahun commented 1 year ago

Hi, still would be nice to have such an option! (example - Dex supports public clients).