search

fykosak / fks-texmf

XeLaTeX makra pro FYKOS a Výfuk
0 stars 5 forks source link

move def from tex to cls file, name "hotfix" to be avoided #81

Closed rzehumat closed 1 year ago

rzehumat commented 3 years ago

Meggy's function

můj hotfix, který přepočítává procenta za minulé série na procenta za celý ročník

Necessary to make batches -- otherwise making the list of participants will fail. Before it was manually written to every batch*/batch*.tex, which is a bad practice

TODO: rename it. Name hotfix is to be avoided. But I don't know, where is it used. Maybe somewhere in processing data from db.

rzehumat commented 3 years ago

Seems it is used only in fkstemplates/year/Makefile. So this will be easy I hope.

I recommend naming it calcYearPercent or something similar.

rzehumat commented 3 years ago

BTW: Do we have any policy about docstrings and casing? If not, we should agree on one.

rzehumat commented 3 years ago

See https://github.com/fykosak/fks-templates/pull/20