fylein / sageintacct-sdk-py

Python SDK to access Sage Intacct web services
MIT License
26 stars 27 forks source link

Appayments api component should either append legacy to get_all method #75

Closed ryanhonea-horne closed 5 months ago

ryanhonea-horne commented 5 months ago

Current implementation of the get_all method in Appayments is using a legacy function that is significantly limited compared to get_all function in api_base. Currently can't return more than 1000 without doing a custom request.

Hrishabh17 commented 5 months ago

@ryanhonea-horne To get more than 1000 records, you can utilize the get_all_generator method of the base class. Here are some changes that would be required:

list_of_data = ['RECORDNO', 'PRBATCHKEY', 'RECORDTYPE', 'RECORDID', 'FINANCIALENTITY'] response = sdk_connection.ap_payments.get_all_generator(fields=list_of_data)