Inconsistent error message for archive

[fymbc]

Similar to edit, when doing archive 0, following is thrown

Whereas doing archive 8, following is thrown

May I suggest for the team to standardise the error message for both, given that they are both of the same branch of error (invalid indexes)

[nus-se-script]

Team's Response

• This seems like a suggestion.
• Also, we think these are 2 different inputs. 0 is out of range but 8 is a possible index.

  Items for the Tester to Verify

  :question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: It seems like a suggestion because I provided an example on how to best fix the method.

If you want the error, 8 is not a possible index for a list of 6 people long. If you want to truly define "out of range", a simple Google search will inform you that it is a value outside the expected range of values. This is the same reason why programming languages throw an error or exception (Python's IndexError, for example) when a user input for an index is invalid/unexpected.

Your screenshot of the bug guide also implies that aside from the suggestion, my report lacks justification as to why the current design is problematic. To reiterate ICYMI, I have already provided this answer in my original report, and I quote: "given that they are both of the same branch of error (invalid indexes)", and relating this to the bug report on EditCommand by stating at the start, "Similar to edit". This is why it is problematic as it does not inform the user of the exact error they are making.

---