search

fyne-io / fyne-cross-images

Repository for managing fyne-cross images
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

Update Go version to 1.20 #16

Closed CryoByte33 closed 1 year ago

CryoByte33 commented 1 year ago

Is your feature request related to a problem? Please describe:

I'm using features new in Go 1.20 for my project, and it fails to compile.

internal/ui_authentication.go:16:6: cmd.WaitDelay undefined (type *exec.Cmd has no field or method WaitDelay)
internal/ui_authentication.go:52:6: cmd.WaitDelay undefined (type *exec.Cmd has no field or method WaitDelay)
note: module requires Go 1.20
[✗] exit status 2

Upon investigation, I saw that the base image is still using Go 1.18.4 and Fyne v2.2.3.

As I develop on an M2 Macbook, fyne-cross is my simplest solution to build for Linux x64 systems consistently.

Is it possible to construct a solution with the existing API?

N/A

Describe the solution you'd like to see:

A simple update to the latest Go and Fyne versions would be more than enough.

Jacalz commented 1 year ago

I’d personally prefer to wait for the 1.20.2 release and not jump on a new Go release too quick. It is usually a good idea to let tools catch up and bugs to get fixed, especially since we basically will be forcing everyone (and every platform) to start using the new version once we update

CryoByte33 commented 1 year ago

Yeah, that's fair.

Maybe in the future it would be possible to add a simple command line argument to override the go version used? It might require using an overlay image on top of base, but would help a lot of early adopters/legacy version users.

That, or have custom different tags for each go version instead of just 1.3-base@latest.

Just an idea, thank you for the response!

Bluebugs commented 1 year ago

With the next version of fyne-cross it will get easier to roll new image without having to roll new fyne-cross itself. So it might not be long before we get there.

As we work toward more automation on building those image, it might be possible to have nightly or something like that. Just throwing an idea here.

jstraarup commented 1 year ago

Go 1.20.2 has now been released. It would be nice if you could upgrade Go when you get the opportunity.

Jacalz commented 1 year ago

Good point. We should probably get that updated now.

Jacalz commented 1 year ago

I realised that this makes more sense in fyne-cross-images, so I transferred it over to there.

Jacalz commented 1 year ago

As of #17 being merged, this is now resolved. I suspect we will have a new release out once more testing has been done.