Closed lorypelli closed 5 months ago
Have you built the images locally and verified that they work?
Have you built the images locally and verified that they work?
I'm having troubles make go running locally, I don't know why it doesn't want to set the PATH on linux Also having troubles running the docker image...
Have you built the images locally and verified that they work?
I need to change sha256
You should not knowingly open a PR with untested changes. That's very bad practice. If something is work in progress, at least open as a draft
You should not knowingly open a PR with untested changes. That's very bad practice. If something is work in progress, at least open as a draft
Now I managed to test
@Jacalz building works correctly
I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')
I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')
Surely that is a lot of overhead for version bumps. If you really need it a separate commit for each managed project, but not a whole PR?
Thanks for this, but watch you don't remove important content.
Has this combination of versions worked well for you?
I would like to update also zig version but I wasn't able to find sha256, so I restored it to dev, but I didn't add back the comment, I will try to find the sha but now I don't have time...
I added the comment back for now, you can merge it if you want, it builds correctly
Actually, I wasn't able to run any command inside of the docker container, it wasn't giving output of them, idk why so I recommend you test this locally by yourself
I was able to find it
Updating zig is a high risk operation. Have you tried to build a few application with this new image using fyne-cross and tested them on their target environment.
Updating zig is a high risk operation. Have you tried to build a few application with this new image using fyne-cross and tested them on their target environment.
If you think it can be an issue, let me know and I will revert the change and make another pull request when I will be able to make sure everything works with it
ok, for now I reverted it, let me know if you are able to do some tests with it
I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')
Surely that is a lot of overhead for version bumps. If you really need it a separate commit for each managed project, but not a whole PR?
I agree. One commit for each would be more sensible.
@lorypelli lorypelli requested a review from andydotxyz 3 days ago
I'm not the right person to review this - but others are around who know it well.
Sorry @lorypelli, I think this got superseded by https://github.com/fyne-io/fyne-cross-images/pull/43. Apologies.
I closed this now but you are more than welcome to open a new PR for that workflow misspelling. I don't think there is any need to update fixuid because the latest release of fyne-cross doesn't use it as far as I know.
Let me know if you want something to not be updated, but I think it's better to update everything...