fyne-io / fyne

Cross platform GUI toolkit in Go inspired by Material Design
https://fyne.io/
Other
24.05k stars 1.34k forks source link

Rework MinSize implementation for richtext with wrapping #4890

Open dweymouth opened 1 month ago

dweymouth commented 1 month ago

Checklist

Describe the bug

The current 2-pass implementation seems to have race conditions

How to reproduce

See fyne-contributors Slack discussion from 2024-05-28

Screenshots

No response

Example code

complicated

Fyne version

develop

Go compiler version

n/a

Operating system and version

n/a

Additional Information

No response

andydotxyz commented 1 month ago

I think this also covers the GridWrap layout and widget implementations?

dweymouth commented 1 month ago

Not the widget, I don't think - I believe its minsize is just the template element. I use it extensively and haven't run into the race condition with it. Not sure about the GridWrap layout off the top of my head