Resolve some issues with reopening full screen windows

fyne-io / fyne

Cross platform GUI toolkit in Go inspired by Material Design

https://fyne.io/

Other

25.22k stars 1.4k forks source link

Resolve some issues with reopening full screen windows #5280

Open xfaris opened 4 days ago

xfaris commented 4 days ago

Description:

Resolve the issue of incorrect position when opening a full screen window after it is hidden. Resolve the issue of flickering when the mouse is placed on the taskbar when the full screen window is hidden and opened again.

Checklist:

[x] Tests included.
[x] Lint and formatter run with no errors.
[x] Tests all pass.

Jacalz commented 4 days ago

If the issue is a result of a reach condition then we should solve the race condition instead of sleeping and re-running a function. If we are certain that it is not, we should document clearly why we do it and which issue it relates to.

Do you have an issue number for this problem?

andydotxyz commented 4 days ago

If the issue is a result of a reach condition then we should solve the race condition instead of sleeping and re-running a function. If we are certain that it is not, we should document clearly why we do it and which issue it relates to.

I think they just copied the code from the initial show function. Perhaps factoring that out into a function called from both places would be clearer?

coveralls commented 4 days ago

coverage: 59.995% (+0.02%) from 59.98% when pulling ebf74278cd2197119f5cb54d923a40b40182e6cf on xfaris:develop into b529a322c69f522448fc9ebf0211a7661ff45479 on fyne-io:develop.