fyne-io / fyne

Cross platform GUI toolkit in Go inspired by Material Design
https://fyne.io/
Other
25.14k stars 1.4k forks source link

fyne package mobile apps ignore -name flag #657

Closed xxxserxxx closed 4 years ago

xxxserxxx commented 4 years ago

Describe the bug:

APKs after installation produce an application entry with an icon, but no application name.

To Reproduce:

This depends on the steps in EDIT 2 of #655, which I won't repeat here. The last step after munging the repository is to build the APK; then connect an Android device and install the APK.

$ fyne package -os android -appID ser1.net.healthdiary -sourceDir . -icon assets/hdf.png -name "Health Diary"
$ adb -d install healthdiary.apk
Performing Streamed Install                                                                     
Success        

Once installed, the application has either no name or "."; according to the Android app info screen, it's name is "ser1.net.healthdiary".

Screenshots:

On the Launcher (the very first application):

screenshot

And querying Android for the app info:

appinfo

Device (please complete the following information):

andydotxyz commented 4 years ago

Thanks. I think that the mobile build is determining name from the directory (which you specified as "."). It should not ignore the -name parameter. Thanks for reporting

andydotxyz commented 4 years ago

Fixed on develop ready for testing

xxxserxxx commented 4 years ago

Confirmed fixed.