search

fyne-io / systray

a cross platfrom Go library to place an icon and menu in the notification area
Apache License 2.0
223 stars 41 forks source link

Use atomic.Bool instead of abool #56

Closed dkess closed 7 months ago

dkess commented 11 months ago

This is in the Go standard library now, so no need to pull in an external library.

andydotxyz commented 11 months ago

Sorry, Fyne is in the process of moving from 1.14 to 1.17 minimum - we can't up to 1.19 for a while.

Jacalz commented 11 months ago

You can use the atomic API that operates on pointers to uint32 or int32 and just set to one or zero in the meantime. It is what we are using in Fyne (and abool does internally) so it would both get rid of the dependency but also be more consistent.

Jacalz commented 7 months ago

It looks like I fixed this with https://github.com/fyne-io/systray/pull/71 last week. I'm so sorry @dkess. I forgot that you had this open :/