search

fyne-io / terminal

A graphical terminal emulator for Linux using Fyne
Other
247 stars 37 forks source link

Expose an easy way to run a function upon terminal window change #62

Closed figuerom16 closed 8 months ago

figuerom16 commented 8 months ago

This currently modifies RunWithConnection which is a breaking change. Should this be split out into another function like OnWindowChange?

Returning the rows and cols through the function is nice since those weren't exposed before.

andydotxyz commented 8 months ago

Returning the rows and cols through the function is nice since those weren't exposed before.

I don't understand - the AddListener returns a chan of Config that includes Rows and Cols as exposed fields already...

figuerom16 commented 8 months ago

My apologies. I made this and #57 more complicated than needed.