search

fyne-io / terminal

A graphical terminal emulator for Linux using Fyne
Other
256 stars 38 forks source link

fix buffer cutoff mid escape #71

Closed mgazza closed 8 months ago

mgazza commented 8 months ago

Fix issue when buffer cuts off mid escape sequence

figuerom16 commented 8 months ago

I wonder if this fixes #70

mgazza commented 8 months ago

If you can reproduce 70 then it would be worth tee'ing the stdout to file so you can inspect it. Essentially I have a set of files which I cat to test the console. I noticed that colors were blinking after my most recent change and that is because the ESC state was not continued between buffer processing; so the state.code sort of got added to the previous code. If you undo my potential fix and run the test and inspect the diff of the terms content you will see what i mean.

andydotxyz commented 8 months ago

I wonder if this fixes #70

Yes I wondered that too - I have to get back to the computer where I can replicate it. On my TODO list for tomorrow.

andydotxyz commented 8 months ago

I wonder if this fixes #70

Sadly it doesn't