search

fynnfluegge / codeqai

Local first semantic code search and chat powered by vector embeddings and LLMs
Apache License 2.0
385 stars 46 forks source link

Haskell support added, Bugs fixed in the case of Azure_OpenAI #28

Closed Nisarg1112 closed 7 months ago

Nisarg1112 commented 7 months ago
  1. In the case of Azure_OpenAI - Some bugs are fixed
  2. Added support of Haskell language
  3. Added support of Haskell language in text_splitter module of Langchain. PR for the same - https://github.com/langchain-ai/langchain/pull/16191
fynnfluegge commented 7 months ago

@Nisarg1112 Great work, thanks a lot! Will wait for the merged PR in langchain and merged this then! :)

Edit: Nevermind, merged! Will release this when langchain PR is merged.

fynnfluegge commented 7 months ago

Hey @Nisarg1112 I just checked your PR on langchain. Would recommend to remove all the trailing comma. Maybe your linter has a different setting, but to get things merged asap best practise is to keep the linter rules from the base repo 🙂

Screenshot 2024-01-20 at 19 15 41
Nisarg1112 commented 7 months ago

Hey, @fynnfluegge Sorry I missed these comments!

Sure it makes sense to remove trailing commas. Right now it's already approved actually.

Also, Thanks for merging my PR!