search

fynnfluegge / monet.nvim

Neovim theme inspired by Claude Monet's iconic water lilies
Apache License 2.0
92 stars 4 forks source link

Neo-Tree and Telescope in transparent mode #3

Open Samthesurf opened 10 months ago

Samthesurf commented 10 months ago

When I make monet transparent, and I try to do actions in Neo-Tree like file creation/deletion, the colours suddenly become very difficult to read and it makes transparent not so fun. For Telescope, it removes the line shading that shows where you are in the list. I don't know how to fix those issues, a guide would be appreciated.

fynnfluegge commented 10 months ago

Hi, thank you, good point. I didn't notice the missing highlighted line in telescope 😄 The header in the Neo-tree dialogs are a known issue, it is tricky to solve. I mark this as a bug for now and will at least fix the telescope issue. Neo-tree bug needs some further investigation.

fynnfluegge commented 10 months ago

@Samthesurf Improved the Telescope list highlighting here https://github.com/fynnfluegge/monet.nvim/commit/ad6b83eda754724b04ca307b89c9006d7cad7332 ✅

Regarding the Neo-tree popup headers, I think this an inconvenient highlighting group mapping in Neo-tree. The header caption uses bg of NeoTreeNormal group.

If I set this to a darkgrey color it looks like this which is fine:

Screenshot 2023-12-29 at 11 56 07

But if the popup is closed it looks like this which not nice:

Screenshot 2023-12-29 at 11 56 15

Seems that the header caption needs it's own highlighting group. This must be "fixed" in the Neo-tree repo first.

Samthesurf commented 10 months ago

Thank you very much for fixing the Telescope issue, Very much appreciated.

Samthesurf commented 10 months ago

Question, is it possible to make the pop-up for the file creation, not transparent like every other part?

fynnfluegge commented 10 months ago

@Samthesurf I think currently this is a Neo-tree limitation. I found this similar issue https://github.com/nvim-neo-tree/neo-tree.nvim/issues/753