fysh711426 / UndetectedChromeDriver

GNU General Public License v3.0
166 stars 60 forks source link

Patcher corrupts chromedriver binary on MacOS (M1) #40

Closed Radu-D closed 1 year ago

Radu-D commented 1 year ago

Diff between original and patched driver:

image
image

Error: OpenQA.Selenium.WebDriverException: Cannot start the driver service on http://127.0.0.1:37427/ \ Patcher

Thanks in advance!


Edit: I found that using Encoding.Unicode instead of Encoding.GetEncoding("ISO-8859-1") solves it!

JvB94 commented 1 year ago

PR: https://github.com/fysh711426/UndetectedChromeDriver/pull/41 It's a quick fix. Maybe Encoding.Unicode works also but for me it makes no diffrence to use x64 Version or ARM Version atm and dont have time for more tests atm.

fysh711426 commented 1 year ago

Can x64 chromedriver run on MacOS (M1) ? I don't have a mac test environment.

fysh711426 commented 1 year ago

I'm not sure if Encoding.Unicode will break the binary.

Radu-D commented 1 year ago

Can x64 chromedriver run on MacOS (M1) ? I don't have a mac test environment.

It apparently can.

41 fixes it on M1! Good stuff 👍

Proof:

image
Radu-D commented 1 year ago

Closing. Fix has been merged with #41.