search

fysoul17 / google_maps_place_picker

Place picker on Google Maps for Flutter
MIT License
224 stars 364 forks source link

Autocompletion List is overlapping with "select here" button. #36

Open TharaniP opened 4 years ago

TharaniP commented 4 years ago

Describe the bug In landscape mode, autocompletion list is overlapping with "select here" button. and also autocompletion list is not scrollable.

To Reproduce Steps to reproduce the behavior:

  1. Change the device orientation to landscape mode

  2. Search for some place IMG_0312

  3. See the overlapping error

Expected behavior Autocompletion list should not overlap with "Select here" button and also need option to scroll the suggestion list. Currently autocompletion is not scrollable.

Screenshots

fysoul17 commented 4 years ago

Hi, @TharaniP

Thanks for the suggestion.

However,

  1. Overlapping is not the problem in UX perspective. In desirable scenario, user will anyway have to select one of the result or cancel before pressing 'select here' button. The better solution was actually disabling (or dimming/blocking) other inputs including select here button, but I didn't include the feature as someone won't want blocking user input. So, I am sorry but there is no plan to change only because of UI doesn't looks good like your case since it will be different based on how you implement. What if someone have different 'select here' button, a bit bigger and located on more higher position? Do you still want to shrink result of autocomplete search? I think no, because the result list is way more important information than 'select here' button in such moment. Please let me know if you have better idea in terms of UX perspetive.

  2. Please refer to Google document about details regarding features of autocomplete here. The result is max. 5 always. So there is no need to implement scrolling feature.

TharaniP commented 4 years ago

Thanks for the update.

As soon as result appears, can we hide the keyboard? until user taps on list item, keyboard is not dismissing.

fysoul17 commented 4 years ago

Okay, this is an issue, but I haven't considered using this in landscape mode.

In order to fix this issue, We need to completely recreate search result panel's UI to make it scrollable. Alternative way is implementing close/complete button on the keyboard.

I am not sure when I can implement these features. So if you need it urgently, please fork it to your own repository and modify it as suggested above.