search

fyviezhao / M3D-VTON

Official code for ICCV2021 paper "M3D-VTON: A Monocular-to-3D Virtual Try-on Network"
165 stars 38 forks source link

'add_gan_loss' is not in the command line for training #13

Open sanazsab opened 2 years ago

sanazsab commented 2 years ago

Hi,

why the store action is true in DRM? It does not include in the command line for training. However, FND and BND are dependent on this argument.

parser.add_argument('--add_gan_loss', action='store_true', help='if specified, use gan loss')

Thanks

fyviezhao commented 2 years ago

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

sanazsab commented 2 years ago

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

Thanks,

why they are not used? The accuracy hasn't changed with the gan loss? And why they were added in the code?

sanazsab commented 2 years ago

Actually, the gan loss is not used and thus this line of add_argument is redundant. FND and BND are therefore not used, either.

Because in this case, there is no discriminator and there is just a generator. Thanks for the clarification.