Unhandled exception can occur on null - Githubissues

fyziktom / VirtualEconomyFramework

Framework for economy applications

https://veframework.com/

MIT License

24 stars 7 forks source link

Unhandled exception can occur on null #111

Open martinhoule opened 2 years ago

martinhoule commented 2 years ago

This line can pass null https://github.com/fyziktom/VirtualEconomyFramework/blob/dc368811b37005f151cafc1a23d13c06173cb1df/VirtualEconomyFramework/VEDriversLite/Neblio/NeblioTransactionHelpers.cs#L2434

Resulting to this call (maybe you can also avoid a call to the client if you check null for performance) https://github.com/fyziktom/VirtualEconomyFramework/blob/dc368811b37005f151cafc1a23d13c06173cb1df/VirtualEconomyFramework/VEDriversLite/Neblio/NeblioTransactionsCache.cs#L31

exception will be thrown here https://github.com/fyziktom/VirtualEconomyFramework/blob/dc368811b37005f151cafc1a23d13c06173cb1df/VirtualEconomyFramework/NeblioRestApi/NeblioRestApi.cs#L325

fyziktom commented 2 years ago

@VenkataRoundSqr please check this during the spliting the classes in #126. Thank you.