search

fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre
Eclipse Public License 1.0
94 stars 24 forks source link

Add missing function #1

Closed rufoa closed 8 years ago

rufoa commented 8 years ago

Thanks for making this library - it's very useful!

I've added a function which was missing. Could you push a new build to clojars please?

fzakaria commented 8 years ago

I'm in bed at the moment but first thing in the morning. On 5 Nov 2015 9:15 p.m., "rufoa" notifications@github.com wrote:

Thanks for making this library - it's very useful!

I've added a function which was missing. Could you push a new build to

clojars please?

You can view, comment on, or merge this pull request online at:

https://github.com/fzakaria/slf4j-timbre/pull/1 Commit Summary

  • Added missing overload for -debug
  • Bumped version

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/fzakaria/slf4j-timbre/pull/1.

rufoa commented 8 years ago

Thanks! (fixes #2) Could you push it to clojars too please

fzakaria commented 8 years ago

Pushed to clojars

fzakaria commented 8 years ago

Thanks @rufo for the fix. I added some more "tests" that just call every log level.

Ideally, I'd like to figure out a way to have Timbre write to a ByteArrayOutputStream and then run some proper tests there. My clojurefu is still new so I will give it a go on the weekend (or contributions welcome!)