search

fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre
Eclipse Public License 1.0
94 stars 24 forks source link

upgrade dependencies #10

Closed fzakaria closed 8 years ago

fzakaria commented 8 years ago

Upgrading Timbre dependency & SLF4J Added tools.reader since its no longer part of Timbre.

fzakaria commented 8 years ago

@rufoa can you take a look. Is there a test we can create to check that it fixes https://github.com/fzakaria/slf4j-timbre/issues/8

rufoa commented 8 years ago

I'm not sure it's possible to catch #8 with a test

As I understand it, It happens because of a dependency conflict when used in conjunction with other libraries, so would not happen when this project is tested in isolation

rufoa commented 8 years ago

but yes this PR seems good to merge and should be a temporary fix for #8