Initial Timbre integration

fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre

Eclipse Public License 1.0

94 stars 23 forks source link

Initial Timbre integration #14

Closed rufoa closed 8 years ago

rufoa commented 8 years ago

populate Timbre :?ns-str with slf4j logger name (the FQN of the log site by convention)
populate Timbre ?:file and ?:line from call stack
put slf4j Marker name, if present, into Timbre :context map with key :marker

closes #12

fzakaria commented 8 years ago

Looks good to me. I would recommend 1 test to validate the line / namespace. Just search/replace that the log statement timbre reports has the test namespace ?

rufoa commented 8 years ago

yeah I've a few tests to add yet

rufoa commented 8 years ago

Improved the existing tests and added the new ones

https://github.com/fzakaria/slf4j-timbre/blob/46fa4423c569d17426ecbc45da26009e9e43f066/test/slf4j_timbre/t_adapter.clj