fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre
Eclipse Public License 1.0
94 stars 24 forks source link

SLF4j actual binding gets unset when importing dgraph4j #38

Closed vxe closed 4 years ago

vxe commented 4 years ago

https://github.com/dgraph-io/dgraph4j

Essentially without this project in deps.edn:

SLF4J: Actual binding is of type [com.github.fzakaria.slf4j.timbre.TimbreLoggerFactory]

adding it results in

 SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]

using these dependencies

        io.dgraph/dgraph4j {:mvn/version "2.0.2"}
        com.taoensso/timbre {:mvn/version "4.10.0"}
        com.fzakaria/slf4j-timbre {:mvn/version "0.3.19"}
        org.slf4j/slf4j-api {:mvn/version "1.7.21"}

Are you able to reproduce and/or know the cause of this?

rufoa commented 4 years ago

Thanks for the report. Will investigate

On Fri, 14 Feb 2020, 05:54 vijay edwin, notifications@github.com wrote:

https://github.com/dgraph-io/dgraph4j

Essentially without this project in deps.edn:

SLF4J: Actual binding is of type [com.github.fzakaria.slf4j.timbre.TimbreLoggerFactory]

adding it results in

SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]

using these dependencies

    io.dgraph/dgraph4j {:mvn/version "2.0.2"}
    com.taoensso/timbre {:mvn/version "4.10.0"}
    com.fzakaria/slf4j-timbre {:mvn/version "0.3.19"}
    org.slf4j/slf4j-api {:mvn/version "1.7.21"}

Are you able to reproduce and/or know the cause of this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fzakaria/slf4j-timbre/issues/38?email_source=notifications&email_token=AAOHHKCKJYKBEH5ZSXTP3TLRCYW23A5CNFSM4KVBKG6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INPCMXQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOHHKHBAYMVYT4LNR3MB3LRCYW23ANCNFSM4KVBKG6A .

rufoa commented 4 years ago

This is a bug in dgraph4j, which lists org.slf4j/slf4j-simple as a compile-time dependency in the default scope. Libraries should not propagate specific slf4j bindings to dependent projects - see the slf4j FAQ.

Please file a bug report with dgraph4j, telling them to scope their dependency on org.slf4j/slf4j-simple correctly to stop it propagating to other people's projects. You could link them to this comment.

A temporary workaround for you, until dgraph4j fix their project, is to manually exclude it from your project dependencies:

Please confirm this fixes your problem. Thanks

vxe commented 4 years ago

work around worked, and bug report filed. Great work on this project!