search

fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre
Eclipse Public License 1.0
94 stars 23 forks source link

Including `slf4j-timbre` in Timbre core's unit tests? #71

Open ptaoussanis opened 9 months ago

ptaoussanis commented 9 months ago

Hi there!

What would you think of perhaps having a unit test in Timbre's core for slf4j-timbre? Might be a good way to help ensure that I don't accidentally break anything on your side when releasing new versions of Timbre.

If you agree this might make sense, could I maybe impose on you to submit a small PR against Timbre? I'm not too familiar with slf4j-timbre internals or config - so you'd probably be in a better position than me to choose a useful test.

Otherwise I'll try take a look at this myself next time I'm doing batched work on Timbre.

Thanks so much for all your work on slf4j-timbre!

Cheers :-)

rufoa commented 7 months ago

Hi @ptaoussanis! That sounds like it could be a good idea. I'm similarly largely unfamiliar with timbre's internals, but I'll look into what can be done.

ptaoussanis commented 4 months ago

@rufoa Hi Rufus! Just an update to share that I'm planning to add out-the-box SLF4J integration to an upcoming version of Timbre later this year.

I've got a working prototype ready for Telemere and plan to back-port that to Timbre along with many other improvements around Jul-Aug. This will include Marker and MDC support, and will include tests in Timbre's suite.

Mentioning now since I suspect the current issue probably won't be worth the effort any more.

To be clear: I really appreciate all your awesome work over the years on slf4j-timbre - and I'm sure its many users do too! But on reflection I do think it's probably a better idea to have SLF4J support directly integrated in core to help prevent accidental breakages and to ease testing, etc.

If you're up for it, I'd love to ping you closer the time to get your expertise on reviewing the final implementation?

rufoa commented 3 months ago

Thanks @ptaoussanis! This sounds like a great move which I support entirely. Thank you for your continued work on this and your kind words.

It's regrettable that I can no longer dedicate to this project the time and attention which it deserves. I also agree that first-class support for SLF4J in timbre makes most sense. This is bound to simplify the implementation of features, and in some cases may be the only way to properly achieve this (I'm thinking of compile-time elision).

Do feel free to contact me if I can be of any help in future! (or when it's time to archive this project and put a message in the readme)

fzakaria commented 3 months ago

You've been a great steward / maintainer @rufoa 🙏