search

fzakaria / slf4j-timbre

SLF4J binding for Clojure's Timbre
Eclipse Public License 1.0
94 stars 24 forks source link

Incompatable w/ slf4j-jdk-platform-logging 2.0 #72

Closed rschmukler closed 1 month ago

rschmukler commented 10 months ago

Thanks for all your work on this library and the upgrade to slf4j 2.0!

I've noticed that using slf4j-timbre with a library that depends on slf4j-jdk-platform-logging will result in the JVM exiting after attempting to call functions that don't exist in adapter.clj.

Specifically it looks like the adapter is expected to provide a -isEnabledForLevel method as well as handle a call within performLog to a new method -makeLoggingEventBuilder.

I played with implementing the methods locally but wanted to confirm if this is actually something that adapter.clj should handle. Similarly, is there a reference to any other methods that 2.0 is expecting the adapter to implement that are also missing? Alternatively, perhaps this is an issue with the SLF4JPlatformLogger implementation using non-standard methods?

Again, thanks for all the work in this and sorry I am not familiar enough with the SLF4J ecosystem / 2.0 upgrade to know what the right course of action is.

ptaoussanis commented 1 month ago

@rschmukler Hi Ryan - in case this is still relevant for you, you might want to try Timbre v6.6.0-RC1 which now includes built-in SLF4J(v2) support.

rschmukler commented 1 month ago

Thanks @ptaoussanis - much appreciated it! Probably can just close this issue then.