fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.8k stars 3.57k forks source link

[fix] complies with psr-2 #2005

Closed rymiyamoto closed 4 years ago

rymiyamoto commented 4 years ago

I refactored some methods which were not psr-2 compliant.

Please review.

codecov-commenter commented 4 years ago

Codecov Report

Merging #2005 into master will decrease coverage by 1.29%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2005      +/-   ##
============================================
- Coverage     56.56%   55.26%   -1.30%     
  Complexity     2068     2068              
============================================
  Files           306      306              
  Lines          4849     4849              
============================================
- Hits           2743     2680      -63     
- Misses         2106     2169      +63     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/de_DE/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/he_IL/Address.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/hu_HU/Address.php 15.38% <0.00%> (-30.77%) 6.00% <0.00%> (ø%)
src/Faker/Provider/uk_UA/Company.php 28.57% <0.00%> (-28.58%) 3.00% <0.00%> (ø%)
src/Faker/Provider/fa_IR/Address.php 73.33% <0.00%> (-26.67%) 7.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php 75.00% <0.00%> (-25.00%) 3.00% <0.00%> (ø%)
src/Faker/Provider/en_IN/Address.php 50.00% <0.00%> (-25.00%) 8.00% <0.00%> (ø%)
src/Faker/Provider/en_ZA/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/nb_NO/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5337ce5...6f421df. Read the comment docs.

rymiyamoto commented 4 years ago

:thinking: PR rebuild