fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.78k stars 3.57k forks source link

Typo in function's name #2031

Open carlos-mora opened 4 years ago

carlos-mora commented 4 years ago

There is a typo in the functions's name, it should be tollFreePhoneNumber instead of tollFreeNumber

pimjansen commented 3 years ago

This will be a breaking change!

carlos-mora commented 3 years ago

@pimjansen The breaking change was to accept the spanish module with a bad named function. The interface spects the function to be called tollFreePhoneNumber instead of tollFreeNumber, so in the current state the spanish language is broken. Try it yourself: Use tollFreePhoneNumber in your current language, be sure it works fine, then change to es_ES language. Are you the reviewer to accept the push? An alternative is to duplicate the function with the right name an keep the old bad_named function, but i think the right answer it to set the function name to the spected one.

carlos-mora commented 3 years ago

According to the docs,

imagen

So the function should keep the name accross languages.