codecov-commenter
commented
4 years ago Codecov Report
Merging #2057 into master will increase coverage by
0.49%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #2057 +/- ##
============================================
+ Coverage 55.90% 56.40% +0.49%
Complexity 2068 2068
============================================
Files 306 306
Lines 4851 4849 -2
============================================
+ Hits 2712 2735 +23
+ Misses 2139 2114 -25 | Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| src/Faker/ORM/Doctrine/Populator.php | 0.00% <ø> (ø) |
11.00 <0.00> (ø) |
|
| src/Faker/Provider/ru_RU/Person.php | 47.36% <100.00%> (-10.53%) |
8.00 <0.00> (ø) |
|
| src/Faker/Provider/en_IN/Person.php | 0.00% <0.00%> (-100.00%) |
1.00% <0.00%> (ø%) |
|
| src/Faker/Provider/hr_HR/Company.php | 0.00% <0.00%> (-100.00%) |
1.00% <0.00%> (ø%) |
|
| src/Faker/Provider/es_PE/Person.php | 50.00% <0.00%> (-50.00%) |
2.00% <0.00%> (ø%) |
|
| src/Faker/Provider/ne_NP/Person.php | 0.00% <0.00%> (-50.00%) |
2.00% <0.00%> (ø%) |
|
| src/Faker/Provider/en_ZA/Address.php | 25.00% <0.00%> (-50.00%) |
4.00% <0.00%> (ø%) |
|
| src/Faker/Provider/es_VE/Company.php | 50.00% <0.00%> (-50.00%) |
2.00% <0.00%> (ø%) |
|
| src/Faker/Provider/fi_FI/Address.php | 66.66% <0.00%> (-33.34%) |
3.00% <0.00%> (ø%) |
|
| src/Faker/Provider/sr_Latn_RS/Address.php | 66.66% <0.00%> (-33.34%) |
3.00% <0.00%> (ø%) |
|
| ... and 42 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1fcc343...113bb19. Read the comment docs.
localheinz
Faker\Provider\ru_RU\Person uses suffix "a" to make a female last name from male, but letter is a latin "a" (ASCII #97) and not cyrillic "a" (ASCII #208), so the final last name is "some cyrillic symbols" + "latin a", commit fixes that, now female last name forms correctly: cyrillic male last name + cyrillic "a".