fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.79k stars 3.59k forks source link

adding JCB card #2058

Open mihaileu opened 4 years ago

mihaileu commented 4 years ago

Adding JCB card type

codecov-commenter commented 4 years ago

Codecov Report

Merging #2058 into master will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2058      +/-   ##
============================================
+ Coverage     56.56%   56.79%   +0.22%     
  Complexity     2068     2068              
============================================
  Files           306      306              
  Lines          4849     4849              
============================================
+ Hits           2743     2754      +11     
+ Misses         2106     2095      -11     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/Payment.php 90.00% <ø> (ø) 23.00 <0.00> (ø)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/ko_KR/Address.php 60.00% <0.00%> (-40.00%) 5.00% <0.00%> (ø%)
src/Faker/Provider/ka_GE/Address.php 57.14% <0.00%> (-28.58%) 7.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php 75.00% <0.00%> (-25.00%) 3.00% <0.00%> (ø%)
src/Faker/Provider/en_GB/Address.php 25.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/ja_JP/Address.php 76.19% <0.00%> (-23.81%) 8.00% <0.00%> (ø%)
src/Faker/Provider/en_UG/Person.php 60.00% <0.00%> (-20.00%) 5.00% <0.00%> (ø%)
src/Faker/Provider/hu_HU/Person.php 60.00% <0.00%> (-20.00%) 5.00% <0.00%> (ø%)
src/Faker/Provider/fr_CA/Address.php 60.00% <0.00%> (-20.00%) 5.00% <0.00%> (ø%)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5337ce5...bd6ef22. Read the comment docs.

mihaileu commented 4 years ago

@pimjansen @fzaninotto still alive ?