fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.8k stars 3.57k forks source link

Enhancement: Raise error level from 6 to 5 #2082

Closed localheinz closed 3 years ago

localheinz commented 3 years ago

This PR

Follows #1897.

codecov-io commented 3 years ago

Codecov Report

Merging #2082 into next will decrease coverage by 0.62%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               next    #2082      +/-   ##
============================================
- Coverage     70.96%   70.34%   -0.63%     
  Complexity     1600     1600              
============================================
  Files           287      287              
  Lines          3864     3864              
============================================
- Hits           2742     2718      -24     
- Misses         1122     1146      +24     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/es_AR/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/he_IL/Address.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/es_PE/Person.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/id_ID/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/fa_IR/Company.php 33.33% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/cs_CZ/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/fi_FI/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/sr_RS/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/es_ES/Person.php 75.00% <0.00%> (-25.00%) 3.00% <0.00%> (ø%)
src/Faker/Provider/en_GB/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0c661e...76c205f. Read the comment docs.

pimjansen commented 3 years ago

@localheinz why did we reduced the error level exactly?

localheinz commented 3 years ago

@pimjansen

1 is the hardest difficulty!

For reference, see https://psalm.dev/docs/running_psalm/error_levels/.

localheinz commented 3 years ago

Thank you, @pimjansen!