fzaninotto / Faker

Faker is a PHP library that generates fake data for you
MIT License
26.79k stars 3.59k forks source link

Fix: PHP requirement in README.md #2089

Closed localheinz closed 4 years ago

localheinz commented 4 years ago

This PR

codecov-io commented 4 years ago

Codecov Report

Merging #2089 into next will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               next    #2089      +/-   ##
============================================
- Coverage     70.51%   70.43%   -0.08%     
  Complexity     1599     1599              
============================================
  Files           287      287              
  Lines          3863     3863              
============================================
- Hits           2724     2721       -3     
- Misses         1139     1142       +3     
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/de_DE/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/ko_KR/Company.php 50.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/en_IN/Address.php 50.00% <0.00%> (-25.00%) 8.00% <0.00%> (ø%)
src/Faker/Provider/es_AR/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/it_IT/Address.php 75.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/sv_SE/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/ro_RO/Address.php 68.00% <0.00%> (-24.00%) 11.00% <0.00%> (ø%)
src/Faker/Provider/ja_JP/Address.php 76.19% <0.00%> (-23.81%) 8.00% <0.00%> (ø%)
src/Faker/Provider/fi_FI/PhoneNumber.php 33.33% <0.00%> (-16.67%) 6.00% <0.00%> (ø%)
src/Faker/Provider/hu_HU/Address.php 46.15% <0.00%> (-15.39%) 6.00% <0.00%> (ø%)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb0a6d4...b4af9b3. Read the comment docs.

fzaninotto commented 4 years ago

PRs make some noise. Notifications, emails, CI builds, etc.

Making 10 PRs of one line of code each is too much noise.

Please group related changes into larger PRs.

localheinz commented 4 years ago

Thank you, @fzaninotto!

If you feel that this is too much noise, feel free to unsubscribe. My aim is to create pull requests that can be easily reviewed, and only contain related changes.