fzaninotto / screenshot-as-a-service

Website screenshot service powered by node.js and phantomjs
1.1k stars 242 forks source link

allow options specified in yaml to be passed to phantomjs #74

Open Woodya opened 9 years ago

Woodya commented 9 years ago

This is something i had done to support our use case (which is to pass --ssl-protocol=tlsv1).

i see that this basic need is referenced by both: #66 and #31, of the two, @slorber 's use of yaml list is more versatile.

I have not updated the default yaml as that's a per project decision, and i don't want to go changing other people's default behavior. eg. don't use =any, we use tlsv1

At any rate. this issue needing fixing for us, and i see others have fixed it in various ways without getting merged. Hopefully a very isolated change that doesn't affect default behavior will make the cut..