search

fzhu2e / LMRt

LMR Turbo, a lightweight implementation of the LMR framework
https://fzhu2e.github.io/LMRt
GNU General Public License v3.0
9 stars 4 forks source link

Is spham a python package and how to install it #1

Open liuhuanxg opened 2 years ago

liuhuanxg commented 2 years ago

utils.py used spham but don't install,why?

fzhu2e commented 2 years ago

Hi, you'll need to install by conda install -c conda-forge pyspharm.

BTW, pyspharm is NOT supported on Apple M1/M2 chips yet.

liuhuanxg commented 1 year ago

ok，I can install it in mac and linux，but can't install it in windows

liuhuanxg commented 1 year ago

I found some small bugs. How can I submit a merge request,?

  1. like visual.py file line 514. "if in_notebook" is always True,in_notebook is a func, it should be "if in_notebook()".
  2. I installed LMRt==0.7.5 package, pathlib package is used in file visual.py but not import, I don't find this question in master, Do you have the idea to fix the bug of version 0.7.5.
  3. Series is in pyleoclim.core.series, but in LMRt==0.7.5, it import from pyleoclim.core.series.ui
fzhu2e commented 1 year ago

ok，I can install it in mac and linux，but can't install it in windows

Right, it's supported on win-32 but not win-64.

I found some small bugs. How can I submit a mr request. like visual.py file line 514. "if in_notebook" is always True,in_notebook is a func, it should be "if in_notebook()". I installled LMRt==0.7.5 package, pathlib package is used but not import, I don't find this question in master, Do you have the idea to fix the bug of version 0.7.5

Good catch! I just pushed a fix in version 0.8.4, please upgrade if possible. If you have found more bugs, you're welcome to submit a pull request. Here is a guide: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Series is in pyleoclim.core.series, but in LMRt==0.7.5, it import from pyleoclim.core.series.ui

This bug has been fixed in version 0.8.3.

It sounds like you'd like to use version 0.7.5 though? Unfortunately it's impossible to modify a released version -- once modified, it's a higher version number, right? : )

If you'd prefer not to upgrade the package, feel free to modify the code locally.

liuhuanxg commented 1 year ago

ok, thank you very much

liuhuanxg commented 1 year ago

Can you add a dev branch or a bug branch? so that I can pull the code. I can't pull code in master branch

fzhu2e commented 1 year ago

Can you add a dev branch or a bug branch? so that I can pull the code. I can't pull code in master branch

The branch "dev" is created.

liuhuanxg commented 1 year ago

when i push code to dev, I received message "ERROR: Permission to fzhu2e/LMRt.git denied to ",Looks like I don't have permission

fzhu2e commented 1 year ago

when i push code to dev, I received message "ERROR: Permission to fzhu2e/LMRt.git denied to ",Looks like I don't have permission

Well, the essential steps to submit a pull request (PR) are:

  1. fork the repo, and a repo will be created under your account
  2. modify the code and push to your repo
  3. click the "pull request" button on Github and submit it