fzi-forschungszentrum-informatik / TSInterpret

An Open-Source Library for the interpretability of time series classifiers
BSD 3-Clause "New" or "Revised" License
115 stars 8 forks source link

Paper fixes #24

Closed britta-wstnr closed 1 year ago

britta-wstnr commented 1 year ago

Hi @JHoelli ,

here are some small fixes I propose to the paper within the frame of the review over at https://github.com/openjournals/joss-reviews/issues/5220 - none of them are related to the content/meaning but more structural. Have a look and see what you think.

Some other things I came across when looking at the paper and the repo:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

JHoelli commented 1 year ago

Hi @britta-wstnr ,

thanks a lot for the fixes. They are looking good. For now I will merge the pull request to have a look at the new PDF and include the rest of your feedback. I will add a comment to https://github.com/openjournals/joss-reviews/issues/5220, when we are finished.

Thanks for organizing and reading the paper.