search

fzi-forschungszentrum-informatik / TSInterpret

An Open-Source Library for the interpretability of time series classifiers
BSD 3-Clause "New" or "Revised" License
115 stars 8 forks source link

Trying to use COMTE and TSR but facing when plotting features #43 #44

Closed JanaSw closed 12 months ago

JanaSw commented 12 months ago

Hello,

I am doing multivariate time series classification with 2 features. When using the plot function with either COMTE or TSR only a portion of the features are being plotted for each instance.

When I debugged I suspected an issue with the reshape done in the plot.

BEFORE Reshape: In the below screenshot is the item values we can see 2 features starting both from 0 value:

image

AFTER Reshape: here we see that the reshape didn't conserve all the values of the feature (we can that not both features are starting at 0)

image

This is happening inside both plot functions: plot_in_one in CF.py at line 181 when it reshape the item and plot in Saliency_Base.py at line 61 when it reshape the item

Note: I am using tensorflow

can you please help ? am I missing something or there is a bug ?

JanaSw commented 12 months ago

Hello @JHoelli

Thank you for your reactivity !

Since you marked it as a bug do you have any estimations when will you submit a fix?

JHoelli commented 12 months ago

Hi,

I am currently fixing it. I hope to finish it in a few hours (afternnon / evening CEST ). (Checking for side effects unfortunately needs some time).

JHoelli commented 12 months ago

Hi @JanaSw,

you can install the patch with pip install https://github.com/fzi-forschungszentrum-informatik/TSInterpret/archive/refs/heads/swpaxes.zip would be great if you could provide feedback, before I merge everything into the main branch.

Thanks for reporting the issue.

JanaSw commented 12 months ago

Hello @JHoelli

I tested it and debugged and checked the values it is indeed working now :)

Thanks again for your reactivity !!

JHoelli commented 12 months ago

Great, I just merged it in the Main Branch. The code will be available via PyPi with Release 0.4.4. (The release might take one or two more weeks.)