search

fzi-forschungszentrum-informatik / TSInterpret

An Open-Source Library for the interpretability of time series classifiers
BSD 3-Clause "New" or "Revised" License
115 stars 8 forks source link

The naming issue of NativeGuideCF #61

Closed LbzSteven closed 6 months ago

LbzSteven commented 6 months ago

Thanks for providing this package.

Motivation. For the counterfactual-based method NativeGuideCF, there are several modes of and I think the naming is quite confusing. In method=='NUN_CF', it performed counterfactual_generator_swap and in 'NG' it performed finding the nearest unlike neighbor (NUN). According to the original paper, it seems that NUN_CF as their comparison method is finding NUN and their proposed method NG conducted counterfactual_generator_swap.

Describe the solution you'd like Swap the names of those methods should solve the problem.

Additional context Add any other context or screenshots about the feature request here.

LbzSteven commented 6 months ago

I didn't notice it was already reported. I will close this thread.