search

fzi-forschungszentrum-informatik / robot_folders

robot_folders helps you managing multiple source projects with their own workspaces mainly around the ROS ecosystem.
MIT License
45 stars 4 forks source link

Add more default aliases #36

Closed fmauch closed 2 months ago

fmauch commented 3 months ago

I'd like to not merge this immediately, as I'd like some feedback on this by users first. @Oberacda maybe you have an opinion on this

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.73%. Comparing base (4e85e99) to head (f29e547). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ======================================= Coverage 52.73% 52.73% ======================================= Files 27 27 Lines 1479 1479 ======================================= Hits 780 780 Misses 699 699 ``` | [Flag](https://app.codecov.io/gh/fzi-forschungszentrum-informatik/robot_folders/pull/36/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fzi-forschungszentrum-informatik) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fzi-forschungszentrum-informatik/robot_folders/pull/36/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fzi-forschungszentrum-informatik) | `52.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fzi-forschungszentrum-informatik#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Oberacda commented 3 months ago

I like having the "fm" and "fmcp" aliases. Concerning the "fmc" and "makecol" alias, I would remove the second one to avoid duplication. I would also suggest adding "fmr" and removing "makeros" for consistency. I favour shorter aliases, which are also more unique to robot folders.

fmauch commented 3 months ago

Yes, I was thinking about this. However, I probably would go for deprecating makecol and makeros in a first step. This is why I wanted this to take some time as I want to avoid deprecating what I am just doing in a couple of months...

fmauch commented 2 months ago

I'll merge this change for now. Deprecating makecol should be done before making a new release