Closed fmauch closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 10.00000%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 52.51%. Comparing base (
d647765
) to head (f6603fd
).
Files | Patch % | Lines |
---|---|---|
src/robot_folders/helpers/environment_helpers.py | 0.00% | 16 Missing :warning: |
src/robot_folders/helpers/ros_version_helpers.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey!
I was able to get this working. As you described, the ROS distribution will say None
but the initial compilation still starts, if I have my ROS sourced beforehand.
After switching branches of robot_folders I managed to run into this issue of catkin_tools. But I don't know if that is related at all.
Thanks for testing this out @DariusPietschatConbotics. I don't really know why I left this as a draft. But since it is working for you I guess, this can get merged.
People might install ROS by themselves differently, e.g. though a source installation which does not install into /opt/ros or through Robostack.
This commit allows having an empty / non-existing /opt/ros without dying when creating environments (both, catkin and colcon workspaces). The output states that the distro 'None' is used, sourcing without an existing build states that users should take care about sourcing their ROS installation. Building without a source ROS installation will probably lead to errors in the output, but I would leave that to the user's responsibility for now.
E.g. requesting a colcon workspace without an existing ROS installation leads to
Closes #38
@DariusPietschatConbotics if you could test that, that would be really nice!