search

fzi-forschungszentrum-informatik / ros2_ros_bt_py

This is a Behavior Tree library meant to be an alternative to SMACH, FlexBE and the like. It includes a ReactJS-based web GUI and all the building blocks you need to build moderately advanced mission control Behavior Trees without writing a single line of code!
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Fix internal state machine of action node #63

Closed Oberacda closed 5 months ago

Oberacda commented 5 months ago

The implicit state machine in the action node was not implemented correctly. This PR implements the state machine explicitly and fixes the invalid transitions in the previous one.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 24.44444% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 33.02%. Comparing base (17e31b8) to head (4d8754c).

Files Patch % Lines
ros_bt_py/src/ros_bt_py/ros_nodes/action.py 24.44% 68 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #63 +/- ## ========================================== + Coverage 32.87% 33.02% +0.15% ========================================== Files 37 37 Lines 5415 5453 +38 Branches 1250 1251 +1 ========================================== + Hits 1780 1801 +21 - Misses 3567 3584 +17 Partials 68 68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 months ago

Test Results

 10 files  ±0   10 suites  ±0   5s :stopwatch: ±0s 153 tests ±0  153 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  306 runs  ±0  306 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 4d8754c7. ± Comparison against base commit 17e31b81.

:recycle: This comment has been updated with latest results.