search

fzi-forschungszentrum-informatik / ros2_ros_bt_py

This is a Behavior Tree library meant to be an alternative to SMACH, FlexBE and the like. It includes a ReactJS-based web GUI and all the building blocks you need to build moderately advanced mission control Behavior Trees without writing a single line of code!
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Add set output to abstract action #84

Closed nspielbau closed 2 months ago

nspielbau commented 2 months ago

We want to be able to process the result before setting the outputs...

github-actions[bot] commented 2 months ago

Test Results

 10 files  ±0   10 suites  ±0   27s :stopwatch: ±0s 202 tests ±0  202 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  404 runs  ±0  404 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 45ef06b6. ± Comparison against base commit 525b7942.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@525b794). Learn more about missing BASE report.

Files Patch % Lines
ros_bt_py/ros_bt_py/ros_nodes/action.py 16.66% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #84 +/- ## ====================================== Coverage ? 33.85% ====================================== Files ? 37 Lines ? 5461 Branches ? 1252 ====================================== Hits ? 1849 Misses ? 3552 Partials ? 60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nspielbau commented 2 months ago

The abstract service implementation has an init override where the 'service_name' option is used, this needs to be implemented in the action as well...