search

fzi-forschungszentrum-informatik / ros2_ros_bt_py

This is a Behavior Tree library meant to be an alternative to SMACH, FlexBE and the like. It includes a ReactJS-based web GUI and all the building blocks you need to build moderately advanced mission control Behavior Trees without writing a single line of code!
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

💡 [REQUEST] - node_modules in launch file should be list of strings instead of string with a list of strings #85

Closed nspielbau closed 1 month ago

nspielbau commented 2 months ago

Implementation PR

No response

Reference Issues

No response

Summary

Currently entering line breaks in the node_module list is annoying, we should change this if we can to make the launch files more legible if multiple node modules are included

Basic Example

This:

'node_modules': "['ros_bt_py.nodes', 'ros_bt_py.ros_nodes', 'awesome_package.nodes.services', 'awesome_package.nodes.longnameabc']",

Should be:

'node_modules': [
    'ros_bt_py.nodes', 
    'ros_bt_py.ros_nodes', 
    'awesome_package.nodes.services', 
    'awesome_package.nodes.longnameabc'
]",

Drawbacks

Might be hard to implement, will have a look

Unresolved questions

No response

nspielbau commented 1 month ago

This is a ROS2 Launch thing that we cannot change. Will "fix" through a custom function that is documented in an "Advanced Launch" Section of the Documentation

nspielbau commented 1 month ago

... Closing as PR is merged