fzi-forschungszentrum-informatik / ros2_ros_bt_py

This is a Behavior Tree library meant to be an alternative to SMACH, FlexBE and the like. It includes a ReactJS-based web GUI and all the building blocks you need to build moderately advanced mission control Behavior Trees without writing a single line of code!
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Remove unnecessary verbose logging #97

Closed Oberacda closed 3 weeks ago

Oberacda commented 1 month ago

Closing #11

github-actions[bot] commented 1 month ago

Test Results

  3 files  ± 0    3 suites  ±0   41s :stopwatch: ±0s 181 tests  - 21  181 :white_check_mark:  - 21  0 :zzz: ±0  0 :x: ±0  543 runs   - 48  543 :white_check_mark:  - 48  0 :zzz: ±0  0 :x: ±0 

Results for commit d314b8a5. ± Comparison against base commit bf3fea0a.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.27711% with 67 lines in your changes missing coverage. Please review.

Project coverage is 50.84%. Comparing base (bf3fea0) to head (d314b8a). Report is 4 commits behind head on dev.

Files Patch % Lines
ros_bt_py/ros_bt_py/tree_manager.py 0.00% 37 Missing :warning:
ros_bt_py/ros_bt_py/nodes/getters.py 0.00% 10 Missing :warning:
ros_bt_py/ros_bt_py/nodes/io.py 0.00% 6 Missing :warning:
ros_bt_py/ros_bt_py/node_data.py 25.00% 3 Missing :warning:
ros_bt_py/ros_bt_py/debug_manager.py 0.00% 2 Missing :warning:
ros_bt_py/ros_bt_py/node.py 33.33% 2 Missing :warning:
ros_bt_py/ros_bt_py/nodes/list.py 0.00% 2 Missing :warning:
ros_bt_py/ros_bt_py/package_manager.py 33.33% 2 Missing :warning:
ros_bt_py/ros_bt_py/ros_nodes/subtree.py 0.00% 2 Missing :warning:
ros_bt_py/ros_bt_py/tree_node.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #97 +/- ## ========================================== - Coverage 50.92% 50.84% -0.09% ========================================== Files 58 58 Lines 7348 7409 +61 Branches 1604 1621 +17 ========================================== + Hits 3742 3767 +25 - Misses 3540 3574 +34 - Partials 66 68 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nspielbau commented 1 month ago

LGTM if the removed code is not vital lol

CodeCov looks bad, but I think that is mostly changed lines, not a real drop