fzwoch / obs-vaapi

OBS Studio VAAPI support via GStreamer
GNU General Public License v2.0
118 stars 3 forks source link

VAAPI H.264 on Navi 22 results in bad output when output resolution different from 720p #23

Closed physixcat closed 8 months ago

physixcat commented 8 months ago

Selecting VAAPI H.264 on Navi 22 [Radeon RX 6700/6700 XT/6750 XT/6800M/6850M XT] as Video Encoder (with its default settings) and an output (scaled) resolution above OR below 1280x720 results in recordings looking like this

mpv-shot0004

If I stay at 720p, I get normal output. Selecting VAAPI H.264 (Legacy) encoder with default settings doesn't have this issue

I'm curious what the differences between the two are. Does the first implement a feature not supported on the 6700 XT? Wondering why it would behave like this when switching away from 720p

System info:

obs-studio 1:30.0.1-dmo1 (from deb-multimedia repo)
obs-vaapi 0.4.1
GStreamer 1.22.8
Mesa 23.3.1-4
Linux 6.5.0-4-amd64
Radeon RX 6700 XT
Debian Sid
therealmate commented 8 months ago

Could this be the same issue as https://gitlab.freedesktop.org/mesa/mesa/-/issues/10063?

fzwoch commented 8 months ago

Yeah looks very much like a stride issue like the mesa report. Seems like the GStreamer fix is the culprit. Unfortunately it seems this patch is not back ported to the stable release.

physixcat commented 8 months ago

Damn, I guess I have to contact the Debian multimedia package maintainers then. Thank you

physixcat commented 8 months ago

You were right, the issue is fixed with the patch linked above. deb-multimedia maintainer pushed version 1:1.22.8-dmo2 of gstreamer1.0-plugins-bad:amd64 and libgstreamer-plugins-bad1.0-0:amd64 . Thank you!

fzwoch commented 7 months ago

Looks like https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/099741e35f60499e69a3ba8d79dad9f242bf5a40

Found it's way into GStreamer 1.22.9